17.2: Cherry pickfix-logger-image-suffix

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1923



Merged-by: Mayra Cabrera <mcabrera@gitlab.com>
Approved-by: Jenny Kim <yjeankim@gitlab.com>
Approved-by: Mayra Cabrera <mcabrera@gitlab.com>
Co-authored-by: Jason Plum <jplum@gitlab.com>

gitlab-base: Bring gitlab-logger image tag suffix back

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1922



Merged-by: Jason Plum <jplum@gitlab.com>
Co-authored-by: João Cunha <j.a.cunha@gmail.com>

(cherry picked from commit b493827c

)

c9ef346f Bring image tag suffix back

Co-authored-by: Jason Plum <jplum@gitlab.com>

Set GOTOOLCHAIN=local for all Go build stages

Closes #2033

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1893



Merged-by: Robert Marshall <rmarshall@gitlab.com>
Approved-by: Hossein Pursultani <hpursultani@gitlab.com>
Approved-by: Robert Marshall <rmarshall@gitlab.com>
Co-authored-by: Jason Plum <jplum@gitlab.com>

Set `GOTOOLCHAIN=local` for in the `ENV` for all Go build stages
of the CNG.

This ensures that a project's checked in `toolchain` content from
`go.mod` will not override the version as configured for the CNG
pipelines itself. This greatly increases the likelihood we are
operating as intended, versus floating accidentally based on a
git checkout's content.

See also https://go.dev/doc/toolchain

Closes https://gitlab.com/gitlab-org/build/CNG/-/issues/2033

Changelog: changed

CI Buildx: Trim trailing hyphen-minuses from namespaces

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1886



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: João Alexandre Cunha <j.a.cunha@gmail.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Reviewed-by: Clemens Beck <cbeck@gitlab.com>
Co-authored-by: Clemens Beck <cbeck@gitlab.com>

Sign GitLab.com images with private key

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1901



Merged-by: Robert Marshall <rmarshall@gitlab.com>
Approved-by: Robert Marshall <rmarshall@gitlab.com>
Reviewed-by: Robert Marshall <rmarshall@gitlab.com>
Co-authored-by: Balasankar "Balu" C <balasankar@gitlab.com>

Sign images built on GitLab.com with the private
key if it is defined in addition to the OIDC key.

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

Make buildx replicas tunable at runtime to reduce infrastructure load

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1619



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Clemens Beck <cbeck@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: Dmitry Makovey <dmakovey@gitlab.com>

Fix greedy suffix match

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1898



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Co-authored-by: Dmitry Makovey <dmakovey@gitlab.com>

Enable all the danger defaults

Closes gitlab-org/distribution/team-tasks#1417

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1887



Merged-by: Robert Marshall <rmarshall@gitlab.com>
Approved-by: Hossein Pursultani <hpursultani@gitlab.com>
Approved-by: Robert Marshall <rmarshall@gitlab.com>
Co-authored-by: João Cunha <j.a.cunha@gmail.com>

We have to keep port information for dev builds

Update docker Docker tag to v27.0.2

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1881



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Andrew Patterson <apatterson@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>

Update dependency danger-review to v1.4.1

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1884



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Andrew Patterson <apatterson@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>

UBI: move to perl-interpreter, instead of perl

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1882



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Clemens Beck <cbeck@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: Jason Plum <jplum@gitlab.com>

Include gomplate assets in gitlab-base UBI image

Closes #2041

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1895



Merged-by: Hossein Pursultani <hpursultani@gitlab.com>
Approved-by: Clemens Beck <cbeck@gitlab.com>
Approved-by: Hossein Pursultani <hpursultani@gitlab.com>
Co-authored-by: Balasankar "Balu" C <balasankar@gitlab.com>

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

Enable tini by default

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1885



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: João Alexandre Cunha <j.a.cunha@gmail.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

Use zstd for compression

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1854



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: Clemens Beck <cbeck@gitlab.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Reviewed-by: Jason Plum <jplum@gitlab.com>
Reviewed-by: Clemens Beck <cbeck@gitlab.com>
Reviewed-by: Emily Chui <echui@gitlab.com>
Co-authored-by: Emily Chui <echui@gitlab.com>

Clean up code following DRY practices. Ensure compression algorithm and
compression level is appended to container_versions across container
images.

Fix ctags

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1890



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: John Mason <9717668-johnmason@users.noreply.gitlab.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Co-authored-by: Dmitry Gruzd <dgruzd@gitlab.com>

Update dependency aws/aws-cli to v1.33.16

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1876



Merged-by: Robert Marshall <rmarshall@gitlab.com>
Approved-by: Alec Xu <axu@gitlab.com>
Approved-by: Robert Marshall <rmarshall@gitlab.com>
Reviewed-by: Alec Xu <axu@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>

- Updates dependency aws/aws-cli from
  v1.33.11 to v1.33.16

Changelog: changed

Add gomplate to UBI-8 gitlab-base image

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1879



Merged-by: Jason Plum <jplum@gitlab.com>
Approved-by: João Alexandre Cunha <j.a.cunha@gmail.com>
Approved-by: Jason Plum <jplum@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

Dangerfiles are located by default under the danger/**/*. So this change
moves dangerfiles there to simplify configuration.

By calling import_dangerfiles instead of importing single files
separately, we'll also inherit all the Dangerbot rules. Including the
reviewer roulette: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles#rules

Closes https://gitlab.com/gitlab-org/distribution/team-tasks/-/issues/1417

Trim trailing "-" from K8s namespaces.

Under rare conditions, a long commit ref slug could be truncated at a "-",
which would result in an invalid K8s namespace.

Previously tini could be activated by setting `USE_TINI=1`. We've
rolled this out fully on GitLab.com on both the production and staging
fleet (https://gitlab.com/gitlab-com/gl-infra/production/-/issues/18186),
and we've seen zombie processes disappear completely as a
result.

Make tini the default now that this appears to be working well.

Changelog: changed

Update gitlab-org/container-registry from v4.5.0-gitlab to v4.6.0-gitlab

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1883



Merged-by: Jaime Martinez <jmartinez@gitlab.com>
Approved-by: Jaime Martinez <jmartinez@gitlab.com>
Co-authored-by: deps <bot@dependencies.io>

Changelog: changed

Changelog: changed

[ci skip]

Now that gitlab-base has gomplate, we no longer need to import
this in a number of containers:

- gitaly
- gitlab-pages
- gitlab-rails
- gitlab-shell
- gitlab-workhorse

Note that gitlab-container-registry still needs this since it
inherits from the UBI image instead of gitlab-base.

Move to installing `perl-interpreter` package in place of `perl`,
this reduces the footprint significantly.

`perl`:
  Installing:      174 packages

`perl-interpreter`:
  Installing:      45 packages

Update hairyhenderson/gomplate from 3.11.7 to 3.11.8

See merge request https://gitlab.com/gitlab-org/build/CNG/-/merge_requests/1873



Merged-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Approved-by: Balasankar 'Balu' C <balasankar@gitlab.com>
Co-authored-by: Clemens Beck <cbeck@gitlab.com>
Co-authored-by: deps <bot@dependencies.io>

Changelog: changed

Changelog: changed