This project is mirrored from https://gitlab.com/gitlab-org/gitaly.git.
Pull mirroring updated .
- Jun 24, 2025
-
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
[ci skip]
-
- Jun 18, 2025
-
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
[ci skip]
-
- Jun 17, 2025
-
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
-
GitLab Release Tools Bot authored
-
- Jun 16, 2025
-
-
Sami Hiltunen authored
Remove VerbatimPatchID feature flag Closes #6593 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7945 Merged-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Co-authored-by:
David Kim <dkim@gitlab.com>
-
- Jun 15, 2025
-
-
James Liu authored
go: Update module golang.org/x/text to v0.26.0 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7946 Merged-by:
James Liu <jliu@gitlab.com> Approved-by:
Olivier Campeau <ocampeau@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
- Jun 13, 2025
-
-
David Kim authored
-
- Jun 12, 2025
-
-
GitLab Renovate Bot authored
-
Eric Ju authored
partition: Backup KV state See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7940 Merged-by:
Eric Ju <eju@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Eric Ju <eju@gitlab.com> Reviewed-by:
Sami Hiltunen <shiltunen@gitlab.com> Reviewed-by:
Eric Ju <eju@gitlab.com> Co-authored-by:
Mustafa Bayar <mbayar@gitlab.com>
-
David Kim authored
It was default enabled for a while now so we should remove this feature flag.
-
- Jun 11, 2025
-
-
John Cai authored
gitcmd: Use original repo path for cgroups See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7925 Merged-by:
John Cai <jcai@gitlab.com> Approved-by:
Mustafa Bayar <mbayar@gitlab.com> Reviewed-by:
Sami Hiltunen <shiltunen@gitlab.com> Reviewed-by:
Emily Chui <echui@gitlab.com> Reviewed-by:
Mustafa Bayar <mbayar@gitlab.com> Reviewed-by:
Timothy Schumacher <tschumacher@gitlab.com>
-
GitLab Release Tools Bot authored
-
Divya Rani authored
gitalybackup: Add timeout flag See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7941 Merged-by:
Divya Rani <drani@gitlab.com> Approved-by:
Olivier Campeau <ocampeau@gitlab.com> Approved-by:
Divya Rani <drani@gitlab.com> Co-authored-by:
Mustafa Bayar <mbayar@gitlab.com>
-
Mustafa Bayar authored
We previously included the KV state of a partition during backup, but this state only contains the KV entries for tx.KV() which is storing the keys under "kv/" prefix. But there are some other keys needed for full restoration, such as applied_lsn and relative_path which are not stored under same prefix. In this MR, we are adding new method to transaction manager that will return raw unprefixed KV data of the partition. With this new structure, we will just need to add "p/{$partitionID}" prefix to the all keys during restore as that is a common prefix for applied_lsn and tx.KV() entries.
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Release Tools Bot authored
[ci skip]
-
GitLab Release Tools Bot authored
[ci skip]
-
- Jun 10, 2025
-
-
Mustafa Bayar authored
Currently "partition create" subcommand of gitaly-backup binary uses 5 minute timeout for each BackupPartition RPC calls. In my testing, I have got DeadlineExceeded for a partition with a big repository such as "gitlab-org/gitlab". Here we are adding an option to configure timeout value with a flag, which will use 5m as default value but will enable user to change it if needed.
-
Sami Hiltunen authored
Fix flaky reftable migration tests Closes #6790 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7938 Merged-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Karthik Nayak <knayak@gitlab.com> Approved-by:
Mustafa Bayar <mbayar@gitlab.com>
-
Sami Hiltunen authored
snapshot: Add the snapshot filter See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7917 Merged-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Reviewed-by:
Sami Hiltunen <shiltunen@gitlab.com> Reviewed-by:
Divya Rani <drani@gitlab.com> Reviewed-by:
GitLab Duo <gitlab-duo@gitlab.com> Co-authored-by:
Eric Ju <eju@gitlab.com>
-
- Jun 09, 2025
-
-
Eric Ju authored
Not all files are needed when creating a snapshot. For example, .lock files under refs/heads are unnecessary because the transaction manager already handles concurrency and conflict resolution. Therefore, we need a mechanism to define which files should be included in a snapshot and which should be excluded. This commit introduces two snapshot filter implementations: - Default filter: Previously, we had simple built-in logic that ignored the worktrees and gitlab-worktree directories. The default filter preserves this behavior to ensure consistency with the existing implementation. - Regex-based filter: This filter includes only files that match specific regular expression patterns, providing fine-grained control over what is included in snapshots. Filters are created when the snapshot manager constructs a new snapshot in (*Manager).newSnapshot(). Regular expressions for the regex-based filter are compiled at package level using regexp.MustCompile, so no filter-specific state needs to be initialized. A functional approach is used to keep the logic simple and stateless. Currently, only read-only snapshots use the regex-based filter. Other snapshot types continue to use the default filter for performance, simplicity and avoiding conflicts (a good conflict example can be found at https://gitlab.com/gitlab-org/gitaly/-/issues/5737#note_2527064466).
-
Eric Ju authored
This commit introduces a feature flag to enable or disable the snapshot filter. This allows us to gradually roll out or test the filter without affecting all environments.
-
Sami Hiltunen authored
tools/mod-validator: Update module golang.org/x/mod to v0.25.0 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7932 Merged-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Divya Rani <drani@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Sami Hiltunen authored
The reftable migration tests are not synchronized correctly which leads to flakiness. The test is accessing the repository directly on the disk to check its reference backend. By this time, it's guaranteed the migrator has committed the transaction. However, it isn't guaranteed the transaction has been applied. The test may assert against an arbitrary state in-between applying the transaction. This leads to test failures when the repository state doesn't match what Git expects. This has been patched around by running the test in a loop three times. This may hide some failures but doesn't actually fix the synchronization issue. Fix this problem by checking the reference backend through the API as normal clients would.
-
- Jun 06, 2025
-
-
John Cai authored
housekeeping: Remove AddPackRefsInhibitor Closes #6768 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7924 Merged-by:
John Cai <jcai@gitlab.com> Approved-by:
James Liu <jliu@gitlab.com>
-
John Cai authored
When snapshots are used, the relative path is different for each snapshot. For the purposes of assigning cgroups, we would want the same cgroup for all commands from a repository. To accomplish this, use the original repo path when assigning cgroups.
-
John Cai authored
In some cases, passing in a localrepo.Repo to OriginalRepository() is necessary. Allow OriginalRepository to receive the storage.Repository interface.
-
Olivier Campeau authored
linguist: Increase read limit to 16KiB See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7935 Merged-by:
Olivier Campeau <ocampeau@gitlab.com> Approved-by:
Mustafa Bayar <mbayar@gitlab.com> Approved-by:
Olivier Campeau <ocampeau@gitlab.com> Co-authored-by:
James Liu <jliu@gitlab.com>
-
Emily Chui authored
go: Update module golang.org/x/sync to v0.15.0 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7931 Merged-by:
Emily Chui <echui@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Emily Chui <echui@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
Mustafa Bayar authored
go: Update module github.com/olekukonko/tablewriter to v1.0.7 See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7929 Merged-by:
Mustafa Bayar <mbayar@gitlab.com> Approved-by:
Mustafa Bayar <mbayar@gitlab.com> Co-authored-by:
GitLab Renovate Bot <gitlab-bot@gitlab.com>
-
GitLab Renovate Bot authored
-
GitLab Renovate Bot authored
-
James Liu authored
When we initially implemented [1] language detection in Go with go-enry, we set an arbitrary read limit of 2048 bytes for each object being processed. This allows us to prevent reading especially large objects into memory, and typically a small slice of the file is enough to determine the language used. Recently we've seen an edge case [2] where a TSQL file was mistakenly identified as a plain SQL file. Since plain SQL files are considered "data" rather than "programming" by go-enry, the stats were discarded and caused the language bar in the repository UI to render incorrectly. We can increase the read limit to allow go-enry to process more of the file. I computed the size distribution [2] of .go files in the Gitaly repository to get a rough idea of sizes: 1k: 560 2k: 356 4k: 331 8k: 229 16k: 114 32k: 53 64k: 9 128k: 5 256k: 1 This doesn't cover other languages of course, but gives us an idea of where the new limit could sit. With a 16KiB limit, we can cover the vast majority of files in this example. The memory and performance impact should also be minimal; on `gprd` we see anywhere from 4-15 RPS over a 24-hour period on the CommitLanguages RPC which executes this code, and it's a non-blocking call made by a Sidekiq worker. [1] https://gitlab.com/gitlab-org/gitaly/-/merge_requests/4580 [2] https://gitlab.com/gitlab-org/gitlab/-/issues/508982 [3] https://superuser.com/a/1100340
-
- Jun 05, 2025
-
-
John Cai authored
Disable bundle URI in CICD See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7933 Merged-by:
John Cai <jcai@gitlab.com> Approved-by:
John Cai <jcai@gitlab.com> Co-authored-by:
Olivier Campeau <ocampeau@gitlab.com>
-
Olivier Campeau authored
Custom runners were created to support bundle URI in the gitaly CICD pipelines. They can be used with the runner tag `bundle-uri`. However, those runners do not exists on the security project, wihch runs the job to scan for security issues. This is causing the jobs to be stuck because no runners are available. This commit reverts the enabling of bundle URI for the Gitaly project in order to unblock the security pipeline. We will find a way to make it work with bundle URI at another time.
-
GitLab Renovate Bot authored
Change the AutoFormat assignment from bool to State type as expected: See: https://github.com/olekukonko/tablewriter/issues/261
-
Sami Hiltunen authored
housekeeping: Do not rollback after commit has already happened See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/7926 Merged-by:
Sami Hiltunen <shiltunen@gitlab.com> Approved-by:
Sami Hiltunen <shiltunen@gitlab.com> Reviewed-by:
Sami Hiltunen <shiltunen@gitlab.com> Co-authored-by:
John Cai <jcai@gitlab.com>
-