Skip to content
Snippets Groups Projects
This project is mirrored from https://gitlab.com/gitlab-org/gitaly.git. Pull mirroring updated .
  1. Jul 07, 2022
  2. Jul 06, 2022
  3. Jul 05, 2022
  4. Jul 04, 2022
    • James Fargher's avatar
      Merge branch 'renovate/github.com-kelseyhightower-envconfig-1.x' into 'master' · e48e5751
      James Fargher authored
      go: Update module github.com/kelseyhightower/envconfig to v1.4.0
      
      See merge request gitlab-org/gitaly!4649
      e48e5751
    • Patrick Steinhardt's avatar
      featureflags: Require version and rollout issue URL for flags · 8132c2bb
      Patrick Steinhardt authored
      When creating a new feature flag it is mandatory to create a feature
      flag rollout issue that keeps track of the current status of any flag.
      This issue is used both to not forget about rolling out a flag, and also
      for the sake of documenting whole rollout process. We have nothing in
      our process though that enforces creation of any such issue, and thus it
      happens from time to time that we forget to create it.
      
      Add two new parameters to `NewFeatureFlag()` that document the version a
      flag has been introduced in and the URL of the issue that's tracking the
      rollout. This brings us several benefits:
      
          - It's hard to forget about creating the issue given that you now
            have to specify the link when creating the flag.
      
          - Reviewers immediately spot a missing link and can verify that it's
            referring to the correct flag. Furthermore, they may review the
            rollout issue itself to see whether it documents important
            details.
      
          - When checking up on a feature flag after it has been merged it
            becomes trivial to find the rollout issue as a developer.
      
      Furthermore, this commit also adds a new version parameter to keep track
      of the version a flag has been introduced in. This also makes it easier
      for reviewers to see whether a flag can really already be removed or
      not.
      
      Adjust all existing feature flag definitions to have this information.
      8132c2bb
    • Patrick Steinhardt's avatar
      Merge branch 'full_path_rpc' into 'master' · 293518c0
      Patrick Steinhardt authored
      Add FullPath RPC
      
      See merge request gitlab-org/gitaly!4642
      293518c0
    • James Fargher's avatar
      Implement FullPath · 2d3e1b91
      James Fargher authored
      FullPath reads the path from the repository's gitconfig under the key
      "gitlab.fullpath".
      2d3e1b91
    • James Fargher's avatar
      Add proto for FullPath RPC · 19f47f27
      James Fargher authored
      FullPath will allow fetching the value previously set by the SetFullPath
      RPC. FullPath assists admins to determine which repo on disk is
      associated with which repository on gitlab.
      
      Changelog: added
      19f47f27
    • GitLab Renovate Bot's avatar
    • GitLab Renovate Bot's avatar
    • James Fargher's avatar
      Merge branch 'build/drop-go116' into 'master' · 92c370b8
      James Fargher authored
      build: drop support for Go 1.16
      
      See merge request gitlab-org/gitaly!4522
      92c370b8
  5. Jul 03, 2022
  6. Jun 30, 2022
    • GitLab Release Tools Bot's avatar
      0c72a4ba
    • Patrick Steinhardt's avatar
      repository: Verify behaviour when fetching into pooled repos · fcd94ab1
      Patrick Steinhardt authored
      We don't have any tests right now that verify that fetching into a
      pooled repository is doing the right thing. Most imporantly, we don't
      assert that we ignore alternate references present in the object pool.
      This missing test coverage had been biting us because we were indeed
      including alternate references in the reference negotiation phase before
      this was fixed via 2383696d (git: Always disable use of alternate refs
      for git-fetch(1), 2022-06-21).
      
      Add a test to verify that we indeed don't use alternate refs in pooled
      repositories to avoid any future regressions.
      fcd94ab1
    • Patrick Steinhardt's avatar
      gittest: Fix the default path for created repositories · 99599232
      Patrick Steinhardt authored
      If not specified, the `CreateRepo()` test helper falls back to compute a
      default repository path for our hashed storage. This default path is
      wrong though: it's using `newDiskHash()` directly and is thus missing
      the `@hashed` prefix.
      
      Fix this issue by using `NewRepositoryName()` instead. While this should
      not really impact anything, it's still sensible to do the right thing
      and match our production setup.
      99599232
    • Patrick Steinhardt's avatar
      repository: Small set of cleanups for FetchRemote tests · b4f6b3c1
      Patrick Steinhardt authored
      This is a small sot of cleanups for FetchRemote tests to fix up test
      names and use the correct setup helpers.
      b4f6b3c1
    • Patrick Steinhardt's avatar
      repository: Refactor tests to check for changed tags in FetchRemote · 07f2710a
      Patrick Steinhardt authored
      The tests we use to verify that we can correctly detect changed tags in
      FetchRemote are a bit lacking. We don't verify that not fetching any
      tags causes the response to say that nothing has changed, and neither do
      we verify that not fetching any tags with checking disabled does the
      right thing.
      
      Refactor the test to use a set of subtests for each of the scenarios to
      make it easier to understand what exactly we're testing right now and
      extend test coverage.
      07f2710a
    • Patrick Steinhardt's avatar
      repository: Set up secure test server via helper · 9da6d281
      Patrick Steinhardt authored
      One of our tests verifies that we can call `CreateFork()` with a TLS
      enabled server. The setup is currently done manually by assembling all
      the necessary prerequisites, but this is indeed not necessary: the
      `testserver` package handles the setup of TLS-enabled servers just fine
      when the `TLSAddress` is set in the Gitaly configuration.
      
      Use `runRepositoryService()` with a TLS-enabled configuration instead to
      reduce the boilerplate. This also allows us to run these tests with
      Praefect enabled.
      9da6d281
    • Patrick Steinhardt's avatar
      repository: Use helper to dedup repository service setup · 35fdf65b
      Patrick Steinhardt authored
      Many tests in the `repository` manually assemble the service server via
      `testserver.RunGitalyServer()`, which also requires them to pass down
      required dependencies. This is quite boilerplate-y and ultimately not
      needed: we can just convert most of them to use `runRepositoryService()`
      to handle the setup for us.
      
      Do so to reduce the test setup noise.
      35fdf65b
    • Patrick Steinhardt's avatar
      repository: Merge functions to set up repository service server · b489ad97
      Patrick Steinhardt authored
      Both `runRepositoryServerWithConfig()` and `runRepositoryService()` do
      essentially the same and indeed have the same function signature. The
      only difference is that the former one will only return the address,
      while the latter one also returns a gRPC client. This is misleading
      though given the `WithConfig()` suffix, which seems to indicate that it
      can accept a configuration while other functions can't.
      
      Fix this confusion by removing the former function and converting all
      current callers to use `runRepositoryService()` instead. This also
      allows us to get rid of constructing the gRPC client in many cases.
      b489ad97
    • Patrick Steinhardt's avatar
      gittest: Add helper to resolve revisions to an object ID · 712b2ff9
      Patrick Steinhardt authored
      Add helper function to resolve revisions to an object ID, which is a
      frequently used pattern in our tests.
      712b2ff9
    • GitLab Release Tools Bot's avatar
      Update changelog for 14.10.5 · 8ba6ea78
      GitLab Release Tools Bot authored
      [ci skip]
      8ba6ea78