Skip to content
Snippets Groups Projects
This project is mirrored from https://gitlab.com/gitlab-org/gitaly.git. Pull mirroring updated .
  1. Aug 14, 2022
  2. Aug 12, 2022
  3. Aug 11, 2022
  4. Aug 10, 2022
    • John Cai's avatar
      Merge branch 'jc-remove-rate-limit-ff' into 'master' · f3a6e61b
      John Cai authored
      limithandler: Remove RateLimiting feature flag
      
      See merge request gitlab-org/gitaly!4796
      f3a6e61b
    • Toon Claes's avatar
      Merge branch '4257-usermergebranch-does-not-verify-it-got-a-user-name-and-email' into 'master' · 434f167e
      Toon Claes authored
      usermergebranch: add validation for user.{email, name}
      
      Closes #4257
      
      See merge request gitlab-org/gitaly!4800
      434f167e
    • Patrick Steinhardt's avatar
      Merge branch 'pks-operations-convert-test-hook-to-bash' into 'master' · 141ae2fd
      Patrick Steinhardt authored
      operations: Convert test hooks to use Bash instead of Ruby
      
      See merge request gitlab-org/gitaly!4803
      141ae2fd
    • Patrick Steinhardt's avatar
      objectpool: Default-enable pruning of refs to fix reference conflicts · 02082a58
      Patrick Steinhardt authored
      In 018958fb (objectpool: Fix conflicting references when fetching into
      pools, 2022-07-27) we have introduced the logic to enable pruning of
      references when we update an object pool via FetchIntoObjectPool. This
      change was required because we have seen cases where updating object
      pools continued to fail due to conflicting references which exist in the
      pool repository and the member we have been fetching from. By pruning
      any references which don't exist in the member anymore we were able to
      resolve these conflicts and thus this bug.
      
      This change has been rolled out to production on August 3rd without any
      observed issues. So let's default-enable the feature flag guarding this
      code so that the fix will be included in the next release.
      
      Changelog: fixed
      02082a58
    • Karthik Nayak's avatar
      operations: Validate user.{email, name} in UserMergeBranch · f7f7c1e6
      Karthik Nayak authored
      
      While 'UserMergeBranch' verifies that it got a user as part of the first
      request, it doesn't verify that the user actually has a name and email
      set. This leads to an Internal error at a later point when trying to
      create the merge commit because you cannot create merge commits with
      either of them being empty.
      
      This commit improves our validation to check these parameters and return
      an InvalidArgument error if unset. We add a new test
      'TestUserMergeBranch_failure' to test the validation logic in
      'UserMergeBranch'.
      
      Signed-off-by: default avatarKarthik Nayak <knayak@gitlab.com>
      f7f7c1e6
    • Patrick Steinhardt's avatar
      git: Fix warning on startup about Git binary fallback · 96bdc943
      Patrick Steinhardt authored
      Gitaly supports different execution environments with bundled Git and
      distributed Git. If no such execution environment was properly set up
      though we will fall back to try and resolve Git via PATH as a last
      resort. Due to the way our environment constructors are arranged right
      now though the fallback will always be constructed, which ultimately
      leads to a warning that Git wasn't properly configured even though it in
      fact was.
      
      Fix this issue by removing the fallback Git environment from our default
      constructors. Instead, we explicitly construct it only in the case where
      we didn't find any other available execution environment. Like this, we
      can now only print the warning when it actually applies.
      
      Changelog: fixed
      96bdc943
    • Patrick Steinhardt's avatar
      operations: Convert test hooks to use Bash instead of Ruby · 5bcc6ef3
      Patrick Steinhardt authored
      As we're progressing with out conversion of Ruby-based code we're
      drawing ever closer to a future where there is no Ruby in Gitaly's code
      base anymore. Some of our tests still depend on Ruby though because they
      use a set of custom hooks that are implemented in it.
      
      Refactor these scripts to use Bash instead of Ruby. This requires less
      boilerplate code and gets rid of the last set of custom hooks in our
      tests that use Ruby.
      5bcc6ef3
    • Patrick Steinhardt's avatar
      gitaly-hooks: Convert test to use Bash instead of Ruby for hooks · 256f96c4
      Patrick Steinhardt authored
      One of our tests for gitaly-hooks asserts that both the command line
      arguments and environment seen by the process match our expectations.
      This is done by writing some custom hooks, where one of the hooks is
      currently written in Ruby.
      
      Refactor the hook to use Bash instead in order to reduce our reliance on
      Ruby. While at it, convert the test to use `gittest.InitRepo()` instead
      of `gittest.InitRepo()`: we don't depend on any references or objects
      anyway, so there is not much of a point to use a completely seeded
      repository.
      256f96c4
  5. Aug 09, 2022