We have a test asserting a specific error is returned when attempting
to resolve a non-existent name. The 'not-existing.com' address used
in the test has since been registered and no longer results in a
resolving error. Remove the test to have the pipeline pass. We're
probably fine even if we don't test for this specific case.

The `Security/License-Scanning.gitlab-ci.yml` CI template has been
removed upstream resulting in invalid yaml syntax and thus breaking
pipelines. Remove the reference to the non-existent CI template.

[ci skip]

[ci skip]

[ci skip]

[ci skip]

[ci skip]

Backport !6251 to 16-3-stable

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6339



Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>

praefect: Handle replica paths in 'track-repository' and 'track-repositories' subcommands

Closes #5402

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6251



Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Evan Read <eread@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Evan Read <eread@gitlab.com>
Co-authored-by: Will Chandler <wchandler@gitlab.com>

(cherry picked from commit 5649e8da)

f05c9a2b praefect: Assert more track-repositories output
02c2260a praefect: Rename 'repository' to 'relative-path'
6efd1c0c praefect: Use replica paths in track-repository
bfbb8f66 praefect: Use replica paths in track-repositories

[ci skip]

[ci skip]

[ci skip]

Revert introduction of adaptive pack-objects limiter

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6236



Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>

In 023c2a7d (Merge branch 'qmnguyen0711/add-adaptive-limit-to-pack-objects-limit'
into 'master', 2023-08-09), we have introduced new code to add an
adaptive limit to pack-objects. This new limiter is seemingly creating a
memory leak that causes issues in production systems.

Revert this merge request.

Changelog: fixed

This reverts commit 7b56381a, reversing
changes made to da843b37.

Differentiate empty repository restores attempt 2

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6215



Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>

operations: Implement UserRebaseConfirmable in pure git

Closes #4579

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6176



Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Xing Xin <moweng.xx@alibaba-inc.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Co-authored-by: Xing Xin <xingxin.xx@bytedance.com>

Implement a linter to check for the order of testing.TB parameter

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6221



Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>

log: Stop using `logrus.New()`

See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6220



Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>

Globally disable the use of `logrus.New()`. Production code should
obtain a logger via either `log.Default()` or `ctxlogrus.Extract()`,
, while test code should be using `testhelper.NewDiscardingLogEntry()`.

We're about to forbid usage of `logrus.New()`, which sets up a
completely new logger. Tests should instead rather use the logger
provided by the testhelper package.

Refactor our tests to use `testhelper.NewDiscardingLogEntry()`. As tests
in `internal/log` cannot use the "testhelper" package due to an import
cycle, these instead use their own local helper function.

Same as with the preceding commit, the "check" subcommand does not
properly initialize its logging infrastructure. Refactor the code to do
so.

Note that we also refactor the code such that we first load the config
and initialize the logging infrastructure before we start to perform the
checks. This allows us to exit early in case the configuration does not
exist or cannot be parsed, whereas until now we already started printing
status information to the process's standard output.

The gitaly-hooks binary does not initialize the logging infrastructure
and instead uses a custom logger that is getting instantiated via
`logrus.New()`. It thus misses some information that our default logger
would have. Furthermore, this causes us to not replace the gRPC logger
as expected.

Fix these issues by calling `log.Configure()` instead such that the
logging infrastructure is properly initialized.

The gitaly-hooks command has somewhat special logging requirements as
they can neither log to stdout (as this would be used by Git), nor can
they log to stderr (as this would be shown to the user). We thus either
log into a file "gitaly_hooks.log", or alternatively just discard all
log entries altogether.

While this setup logic is thus closely tied to the gitaly-hooks logger,
the setup is contained in the "internal/log" package. Let's move it to
its only user to make things more self-contained and not clutter the
generic log package with highly specialized functionality.