Skip to content
Snippets Groups Projects
This project is mirrored from https://gitlab.com/gitlab-org/gitaly.git. Pull mirroring updated .
  1. Jun 10, 2021
  2. Jun 09, 2021
  3. Jun 08, 2021
    • Patrick Steinhardt's avatar
      Merge branch 'ps-supervisor-config' into 'master' · 22f7db01
      Patrick Steinhardt authored
      Make gitaly supervisor configuration local
      
      Closes #3651
      
      See merge request gitlab-org/gitaly!3571
      22f7db01
    • Patrick Steinhardt's avatar
      Merge branch 'pks-update-remote-inmemory' into 'master' · ed156474
      Patrick Steinhardt authored
      remote: Allow for in-memory remotes in UpdateRemoteMirror
      
      Closes #3649
      
      See merge request gitlab-org/gitaly!3566
      ed156474
    • Pavlo Strokov's avatar
      Make gitaly supervisor configuration local · 123597fd
      Pavlo Strokov authored
      Supervisor for the gitaly-ruby sidecar uses a package global
      variable to store configuration. That causes issues in testing
      as it produces a race conditions some times. The global variables
      is an evil and we try to get rid of them. That change removes
      the global variable and adds a constructor for the Config type.
      Each test now uses a locally defined config variable and there is
      no races on the global variable anymore.
      
      Closes: https://gitlab.com/gitlab-org/gitaly/-/issues/3651
      123597fd
    • Patrick Bajao's avatar
      Auto-resolve other conflict scenarios when AllowConflicts is true · 8ea1987f
      Patrick Bajao authored
      In order to be able to show diffs on based on the merge ref, we
      need to be able to automatically resolve conflicts when
      UserMergeToRef is called with AllowConflicts set to true.
      
      The mergeSubcommand.resolveConflicts has been modified to handle
      scenarios wherein there is a missing side of a conflict (whether
      it's our, their or the ancestor). This update is needed so we can
      show the MR diff even if there are conflicts.
      
      Before this change, we try to git-merge-file
      (via conflicts.MergeFile) using 3 versions of a file from ancestor,
      our, and their but that fails when one of them does not exist.
      With this change, we only do that when 2 of them are present.
      
      When 2 of those aren't present, we "manually" (in code) handle
      conflict resolution by keeping the changes in conflict.Their and
      rejecting other changes in conflict.Our and conflict.Ancestor as
      we don't want them to show up.
      
      Changelog: changed
      8ea1987f
    • Zeger-Jan van de Weg's avatar
      Merge branch 'ash2k/remove-not-found-ff' into 'master' · df2eb006
      Zeger-Jan van de Weg authored
      Remove GrpcTreeEntryNotFound feature flag
      
      See merge request gitlab-org/gitaly!3567
      df2eb006
    • Patrick Steinhardt's avatar
      remote: Allow for in-memory remotes in UpdateRemoteMirror · 01662532
      Patrick Steinhardt authored
      As we're about to phase out usage of on-disk remotes, all RPCs which
      interact with them need to be converted to use in-memory remotes.
      `UpdateRemoteMirror()` doesn't yet have the ability to use them.
      
      Implement support for in-memory remotes by configuring the remote via a
      set of Git configuration environment variables. Until downstream callers
      have been converted from on-disk to in-memory remotes, both ways will
      stay supported. Afterwards, we can drop the `RefName` parameter, which
      really is the remote name.
      
      Changelog: added
      01662532
    • Mikhail Mazurskiy's avatar
      Remove GrpcTreeEntryNotFound feature flag · 7e47739d
      Mikhail Mazurskiy authored
      Changelog: removed
      7e47739d
    • Patrick Steinhardt's avatar
      proto: Use Go identifiers for UpdateRemoteMirror documentation · a6f559d1
      Patrick Steinhardt authored
      When generating Go code from protobuf messages, we always have a
      mismatch between declared variables and generated identifiers. This
      leads to a mismatch in generated documentation, where the variable
      documentation does not start with the Go variable name as it is best
      practice in Go. Because of this, we have started to use Go identifiers
      in protobuf documentation to fix the discrepancy.
      
      Update documentation of variables in messages related to
      UpdateRemoteMirror to do so consistenly.
      a6f559d1
    • Patrick Steinhardt's avatar
      localrepo: Add ability to specify Git config for `Push()` · fa7ba1c0
      Patrick Steinhardt authored
      In order to allow callers to set up in-memory remotes, add the ability
      to specify Git configuration for `Push()` and add a test which exercises
      the new code. This functionality will be used in a subsequent commit.
      fa7ba1c0
    • Patrick Steinhardt's avatar
      localrepo: Refactor `Push()` tests to allow more control over test repo · bd0329e5
      Patrick Steinhardt authored
      We're about to add the ability to pass Git configuration entries to
      `localrepo.Push()`. As the intended use case for this is to allow for
      in-memory remotes when pushing, one of the new testcases will require
      the ability to more tighlty control the push repository setup.
      
      Refactor the test code to prepare for this by always having testcases
      setup their own repositories.
      bd0329e5
    • Patrick Steinhardt's avatar
      localrepo: Add `WithConfig()` option for `GetRemoteReferences()` · f8fd5dd9
      Patrick Steinhardt authored
      Add a new option for the `GetRemoteReferences()` function that allows
      the user to specify Git configuration entries. This easily allows the
      caller to set up in-memory remotes, which we'll require in a subsequent
      commit.
      f8fd5dd9
    • Patrick Steinhardt's avatar
      localrepo: Refactor `GetRemoteReferences()` tests · cf8de39f
      Patrick Steinhardt authored
      As we're about to add another new option which allows the setup of
      in-memory remotes, a newly added testcase will require control over the
      remote that is to be queried. Refactor the tests as a preparatory test
      to explicitly specify their remote.
      cf8de39f
    • Patrick Steinhardt's avatar
      localrepo: Convert `GetRemoteReferences()` to accept options · 94b0b062
      Patrick Steinhardt authored
      We'll need to add additional options to `GetRemoteReferences()` such
      that we can set up in-memory remotes. As a preparatory step, convert the
      function to receive a set of options instead of only patterns to make it
      extensible.
      
      No change in behaviour is expected from this commit.
      94b0b062
  4. Jun 07, 2021
  5. Jun 04, 2021
  6. Jun 03, 2021
  7. Jun 02, 2021
  8. Jun 01, 2021