Support non-UTF-8 file system paths in logging protocol
Linux allows for non-UTF-8 file system paths. Our logging protocol is currently storing paths as strings which in protocol buffers are expected to be UTF-8. To allow for non-UTF-8 paths, convert the protocol buffer types to bytes and adjust the code around it. Only fields that can contain client provided non-UTF-8 data were converted to bytes. Tests covering the UTF-8 support exclude macOS as macOS enforces UTF-8 in paths.
Showing
- internal/gitaly/storage/storagemgr/apply_operations.go 11 additions, 8 deletionsinternal/gitaly/storage/storagemgr/apply_operations.go
- internal/gitaly/storage/storagemgr/transaction_manager_refs_test.go 67 additions, 0 deletions...italy/storage/storagemgr/transaction_manager_refs_test.go
- internal/gitaly/storage/storagemgr/transaction_manager_test.go 2 additions, 2 deletions...nal/gitaly/storage/storagemgr/transaction_manager_test.go
- internal/gitaly/storage/wal/operations.go 3 additions, 3 deletionsinternal/gitaly/storage/wal/operations.go
- proto/go/gitalypb/log.pb.go 27 additions, 12 deletionsproto/go/gitalypb/log.pb.go
- proto/log.proto 18 additions, 3 deletionsproto/log.proto
Please register or sign in to comment