Skip to content
  • beorn7's avatar
    lint: Revamp our linting rules, mostly around doc comments · 0f760f63
    beorn7 authored
    Several things done here:
    
    - Set `max-issues-per-linter` to 0 so that we actually see all linter
      warnings and not just 50 per linter. (As we also set
      `max-same-issues` to 0, I assume this was the intention from the
      beginning.)
    
    - Stop using the golangci-lint default excludes (by setting
      `exclude-use-default: false`. Those are too generous and don't match
      our style conventions. (I have re-added some of the excludes
      explicitly in this commit. See below.)
    
    - Re-add the `errcheck` exclusion we have used so far via the
      defaults.
    
    - Exclude the signature requirement `govet` has for `Seek` methods
      because we use non-standard `Seek` methods a lot. (But we keep other
      requirements, while the default excludes completely disabled the
      check for common method segnatures.)
    
    - Exclude warnings about missing doc comments on exported symbols. (We
      used to be pretty adamant about doc comments, but stopped that at
      some point in the past. By now...
    0f760f63