Merge branch 'sh-consolidate-migration-delete' into 'master'

Consolidate database cleaner code for migrations

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/105600



Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Krasimir Angelov <kangelov@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

spec/support/database_cleaner.rb

@@ -22,14 +22,4 @@
 
     self.class.use_transactional_tests = true
   end
-
-  config.around(:each, :migration) do |example|
-    self.class.use_transactional_tests = false
-
-    example.run
-
-    delete_from_all_tables!(except: deletion_except_tables)
-
-    self.class.use_transactional_tests = true
-  end
 end

spec/support/migration.rb

@@ -45,6 +45,8 @@
       example.run
     end
 
+    delete_from_all_tables!(except: deletion_except_tables)
+
     self.class.use_transactional_tests = true
   end