Skip to content
Snippets Groups Projects
  1. May 23, 2024
  2. May 22, 2024
  3. May 21, 2024
  4. May 17, 2024
  5. May 16, 2024
    • Stan Hu's avatar
      Ensure BLPOP/BRPOP returns nil instead of raising ReadTimeoutError · 53de79ac
      Stan Hu authored
      In https://github.com/redis/redis-rb/issues/1279, we discovered that
      when using BLPOP or BRPOP `redis-rb` properly returned `nil` when
      `timeout` was reached with no key present, but when connecting to
      Redis Sentinels, the client raised a `ReadTimeoutTimeout` error.
      
      This occurred because of a subtle difference in how `RedisClient`
      (from `redis-rb`) and `Redis::Client` (from `redis-client`)
      behaved. The former, which is used with standalone Redis, returned
      `nil` because the socket read timeout was incremented to the command
      timeout value (https://github.com/redis/redis-rb/pull/1175). The
      latter did not have this, so the socket read timeout would get
      triggered before the actual Redis timeout hit.
      
      To make the behavior consistent, increment the configured read timeout
      to the command timeout.
      
      This commit includes the patch in
      https://github.com/redis-rb/redis-client/pull/197 to fix this issue
      until an official redis-client patch release can be made.
      
      Changelog: fixed
      53de79ac
  6. May 15, 2024
  7. May 14, 2024
  8. May 10, 2024
  9. May 08, 2024