Merge branch 'security-fix/security-group-user-removal-11-4' into 'security-11-4'
[11.4] Resolve "Removing a user from a private group doesn't remove them from group's project, if their project's role was changed" See merge request gitlab/gitlabhq!2714
Showing
- app/controllers/concerns/membership_actions.rb 3 additions, 1 deletionapp/controllers/concerns/membership_actions.rb
- app/helpers/members_helper.rb 13 additions, 2 deletionsapp/helpers/members_helper.rb
- app/models/member.rb 1 addition, 0 deletionsapp/models/member.rb
- app/models/members/group_member.rb 2 additions, 0 deletionsapp/models/members/group_member.rb
- app/models/members/project_member.rb 4 additions, 0 deletionsapp/models/members/project_member.rb
- app/services/members/destroy_service.rb 33 additions, 1 deletionapp/services/members/destroy_service.rb
- changelogs/unreleased/fix-security-group-user-removal.yml 5 additions, 0 deletionschangelogs/unreleased/fix-security-group-user-removal.yml
- spec/controllers/groups/group_members_controller_spec.rb 1 addition, 1 deletionspec/controllers/groups/group_members_controller_spec.rb
- spec/helpers/members_helper_spec.rb 2 additions, 2 deletionsspec/helpers/members_helper_spec.rb
- spec/services/members/destroy_service_spec.rb 56 additions, 4 deletionsspec/services/members/destroy_service_spec.rb
Please register or sign in to comment